This repository was archived by the owner on Aug 21, 2018. It is now read-only.
840 course career path(connects #840) #882
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmmrssa
reviewed
Jun 21, 2017
| console.log("before") | ||
| return a > b ? 1 : a < b ? -1 : 0; | ||
| }, | ||
| /*comparator: function(model) { |
lmmrssa
reviewed
Jun 21, 2017
| } | ||
| }) | ||
| console.log(career) | ||
|
|
lmmrssa
reviewed
Jun 21, 2017
| }, | ||
| }, | ||
|
|
||
| initialize: function() { |
Member
There was a problem hiding this comment.
remove this function if nothing is in it.
lmmrssa
reviewed
Jun 21, 2017
| this.vars.Courseid = arrCourseIds | ||
| this.vars.Course_Length = this.collection.models.length-1 | ||
| this.$el.html(_.template(this.template,this.vars)) | ||
|
|
lmmrssa
reviewed
Jun 21, 2017
| $(function(){ | ||
| App.Views.CareersPathTable = Backbone.View.extend({ | ||
| addOne: function(model) { | ||
| //console.log(model) |
lmmrssa
reviewed
Jun 21, 2017
| this.renderView(model) | ||
| // } | ||
| }, | ||
| renderView: function(model) { |
Member
There was a problem hiding this comment.
remove function and code if not used
lmmrssa
reviewed
Jun 21, 2017
databases/multicoursecareerpath.js
Outdated
| @@ -0,0 +1,24 @@ | |||
| var couchapp = require('couchapp'), | |||
| path = require('path'); | |||
lmmrssa
reviewed
Jun 21, 2017
databases/coursecareerpath.js
Outdated
| @@ -0,0 +1,31 @@ | |||
| var couchapp = require('couchapp'), | |||
| path = require('path'); | |||
lmmrssa
suggested changes
Jun 21, 2017
Member
lmmrssa
left a comment
lmmrssa
left a comment
There was a problem hiding this comment.
lot of extra line and unused function. Please clean those
app/MyApp/index.html
Outdated
| </table> | ||
|
|
||
| </div> | ||
|
|
nirojdyola
suggested changes
Nov 3, 2017
app/MyApp/app/Router.js
Outdated
| CareerPath.fetch({ | ||
| async:false | ||
| }); | ||
| console.log(CareerPath) |
Contributor
There was a problem hiding this comment.
I think comments are not needed here .
| courseCareer.set('requiredCareerPathIds',selectedCareerIds); | ||
| courseCareer.save(null, { | ||
| success: function(response){ | ||
| location.reload(); |
Contributor
There was a problem hiding this comment.
Indentation need to be fix.
| }) | ||
| location.reload(); | ||
| } else { | ||
| $('#LCourse option:selected').each(function(){ |
| } | ||
| }, | ||
|
|
||
|
|
Contributor
There was a problem hiding this comment.
extra line should be remove.
| }, | ||
|
|
||
| initialize: function() { | ||
|
|
Contributor
There was a problem hiding this comment.
extra line should be remove.
| }, | ||
|
|
||
| initialize: function() { | ||
|
|
app/MyApp/index.html
Outdated
| <script src="app/views/CareerDetailView.js"></script> <!-- app/views.js --> | ||
| <!-- <script src="app/views/CareerPathTable.js"></script> --><!-- app/views.js --> | ||
|
|
||
|
|
app/MyApp/index.html
Outdated
| <% } %> | ||
| </tbody> | ||
| </table> | ||
|
|
app/MyApp/index.html
Outdated
| </table> | ||
|
|
||
| </div> | ||
|
|
app/MyApp/index.html
Outdated
| </tr> | ||
| <%}%> | ||
| </table> | ||
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.